Pyrdacor / Ambermoon.net

Ambermoon rewrite in C#
GNU General Public License v3.0
420 stars 22 forks source link

Crash on 2D Worldmap #6

Closed Thallyrion closed 4 years ago

Thallyrion commented 4 years ago

I was walking around the worldmap near Spannenberg when a crash occured:

Unhandled exception. Ambermoon.AmbermoonException: [Render] Invalid index at Ambermoon.Renderer.RenderBuffer.GetDrawIndex(ISurface3D surface) at Ambermoon.Renderer.RenderLayer.GetDrawIndex(ISurface3D surface) at Ambermoon.Renderer.OpenGL.Surface3D.AddToLayer() at Ambermoon.Renderer.OpenGL.Surface3D.set_Visible(Boolean value) at Ambermoon.Render.RenderMap3D.AddObject(ISurface3DFactory surfaceFactory, IRenderLayer layer, UInt32 mapX, UInt32 mapY, Object obj) at Ambermoon.Render.RenderMap3D.UpdateSurfaces() at Ambermoon.Render.RenderMap3D.SetMap(Map map, UInt32 playerX, UInt32 playerY, CharacterDirection playerDirection) at Ambermoon.Game.Start3D(Map map, UInt32 playerX, UInt32 playerY, CharacterDirection direction) at Ambermoon.Render.Character2D.MoveTo(Map map, UInt32 x, UInt32 y, UInt32 ticks, Boolean frameReset, Nullable1 newDirection) at Ambermoon.Render.Player2D.Move(Int32 x, Int32 y, UInt32 ticks, Nullable1 prevDirection, Boolean updateDirectionIfNotMoving) at Ambermoon.Game.Move() at Ambermoon.GameWindow.Keyboard_KeyDown(IKeyboard keyboard, Key key, Int32 value) at Silk.NET.GLFW.XC6DECC54.Glfw.PollEvents() at Silk.NET.Windowing.Desktop.GlfwWindow.DoEvents() at Silk.NET.Windowing.Common.WindowExtensions.<>c__DisplayClass2_0.b__0() at Silk.NET.Windowing.Desktop.GlfwWindow.Run(Action onFrame) at Silk.NET.Windowing.Common.WindowExtensions.Run(IView view) at Ambermoon.GameWindow.Run(Configuration configuration) at Ambermoon.Program.Main()

Version 1.09 I could not reproduce it. Occured only once.

Edit: Could reproduce the crash. It randomly occurs on entering another 3D locations. In this case the Orc Caves/Burnville Tunnel Edit2: I don't know if this actually is an issue (could not be implemented yet) not all 3D location are visitable. E.g. entering Sylph/Gala Temple does not work. And in Spannenberg you have no Sky textures, background is just Black.

Metibor commented 4 years ago

This is already fixed with https://github.com/Pyrdacor/Ambermoon.net/pull/5 and should be available in the next build. With v1.09 you are only able to visit one 3D map.

Pyrdacor commented 4 years ago

Will release the fixed version later. ;)

Thallyrion commented 4 years ago

This is already fixed with #5 and should be available in the next build.

Thought the 1.09 was the fixed version as the graphic glitches in Spannenberg were gone

With v1.09 you are only able to visit one 3D map.

This is definately not true. I was able to visit multiple 3D maps with every version including 1.09 . Only with 1.09 it crashed sometimes.

Pyrdacor commented 4 years ago

This is already fixed with #5 and should be available in the next build.

Thought the 1.09 was the fixed version as the graphic glitches in Spannenberg were gone

It should have been but there was a new bug caused by the fix.

With v1.09 you are only able to visit one 3D map.

This is definately not true. I was able to visit multiple 3D maps with every version including 1.09 . Only with 1.09 it crashed sometimes.

I think he meant visiting without bugs. As I mentioned above a new bug with introduced with the fix. It is also fixed but there is no release with that fix yet. But soon. ;)

Pyrdacor commented 4 years ago

This should be fixed in v1.0.10. :)

Thallyrion commented 4 years ago

Crash seems to be fixed. Walked all over the map and entered every 3D map multiple time. No crash.

Pyrdacor commented 4 years ago

Nice. I'll close this issue.

Thallyrion commented 4 years ago

Hi

v1.0.14 download is not working. File is not found.

Am Di., 18. Aug. 2020 um 22:14 Uhr schrieb Pyrdacor < notifications@github.com>:

Closed #6 https://github.com/Pyrdacor/Ambermoon.net/issues/6.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Pyrdacor/Ambermoon.net/issues/6#event-3667954517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSK7RMCDWW5VS34W6ENIPTSBLOJ7ANCNFSM4QDK5UQQ .

Pyrdacor commented 4 years ago

Thank you. Should be there now.