Pyrdacor / Ambermoon.net

Ambermoon rewrite in C#
GNU General Public License v3.0
416 stars 20 forks source link

UI issues #62

Open kermitfrog opened 3 years ago

kermitfrog commented 3 years ago

A place to collect all the UI stuff, that has yet to be fixed...

  1. 3D movement:

    • [ ] possible improvement: right click on move arrow (in 3D window) could move by complete field. Middle click could move/align to center of next field / full 90 degree direction.
    • [ ] moving or turning with keyboard sometimes causes short little speed bursts.
  2. 2D keyboard movement:

    • [ ] Moving with the numpad in 2D moves too much. Even a very short press will move the player by 2, sometimes 3 squares.
  3. Inventory

    • [ ] holding rmb over character to open inventory, then movin mouse to other portrait (without release) should switch to that character.
    • [ ] improvement: Middle clicking item could open look window.
    • [ ] minor improvement: make it possible to configure additional mouse button or key to trigger use item directly.
    • [ ] improvement: The text box in inventory (below the portraits) could display most important item stats when hovering over item.
    • [x] #216
  4. Dialog to choose how much gold/food to give/throw away

    • [ ] improvement: show indicator hands while selecting amount, so you can see if another character can carry that much before confirming.
  5. Keyboard shortcuts for..

    • [x] #218
    • [x] Trigger 3D context action
    • [x] #217
    • [x] Exit 3D map - could use the same keys as the above
  6. Other

    • [x] Use mouse wheel to scroll Options
    • [x] #239
    • Pad bottom of last page
    • Scroll to text, slowly enough for the eyes to follow (my favourite)
    • put a thin dashed line above the first new line (some ebook readers do that with pdfs - works quite well)
    • [ ] the angle from which an action can be performed in 3D is sometimes too tight
Shinhobi commented 3 years ago

First of all Hi There!

Thanks to Pyrdacor for the whole awesomeness of actually bringing Ambermoon back to life and to everyone assisting here. It has been my own dream to relaunch the game at some point and expand it, make it better. I am not at all a programmer, so I will assist in other ways. Maybe with future testing the game or inputs on how to make it better. I have played Amberstar and Ambermoon excessively through Emulator the past few years. So I know the worlds and the mechanics. I have a huge list of things that can be improved or expanded. However my purpose here is not to bring that up, but to assist in successfully cloning the game for new platforms.

Here is my input on 3D Movement. Know "Grimrock" Games 1 and 2? The movement mechanic of those games COULD be applied to Ambermoon. I think it would make it much more maneuverable. so instead of free movement, steps could go from field to field and turns in general 90 degrees. No more bumping into things and less awkward trying to get around objects. Better and faster getting around in the 3D environments. I thought it never made sense the way Ambermoon handles it, although I acknowledge that for the time it was beyond AMAZING to be able to move freely through 3D worlds.

Could be a thing for a game where you spend literally hours moving through sometimes tricky and riddled 3D places.

It's a thought and maybe this is the best point in time to implement anything such?

Pyrdacor commented 3 years ago

Hi there. Thanks for the suggestion.

If we add this, I would do so as an option which can be turned on or off. Unfortunately I don't know Grimrock. But I will have a look at it. ;)

Shinhobi commented 3 years ago

this:

https://www.youtube.com/watch?v=RKvMDNsEc14

On Sun, 31 Jan 2021 at 13:13, Pyrdacor notifications@github.com wrote:

Hi there. Thanks for the suggestion.

If we add this, I would do so as an option which can be turned on or off. Unfortunately I don't know Grimrock. But I will have a look at it. ;)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Pyrdacor/Ambermoon.net/issues/62#issuecomment-770372830, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASPM6H3GCZXUSGD4JPJCBCDS4VCPFANCNFSM4UVDOYQA .

Shinhobi commented 3 years ago

Making it optional in game settings is of course the best solution.

On Sun, 31 Jan 2021 at 13:36, Mathias Müller matheo81@gmail.com wrote:

this:

https://www.youtube.com/watch?v=RKvMDNsEc14

On Sun, 31 Jan 2021 at 13:13, Pyrdacor notifications@github.com wrote:

Hi there. Thanks for the suggestion.

If we add this, I would do so as an option which can be turned on or off. Unfortunately I don't know Grimrock. But I will have a look at it. ;)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Pyrdacor/Ambermoon.net/issues/62#issuecomment-770372830, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASPM6H3GCZXUSGD4JPJCBCDS4VCPFANCNFSM4UVDOYQA .

Shinhobi commented 3 years ago

Hey. Which Issue on Ambermoon.net is best to just dump testing observations in?

On Sun, 31 Jan 2021 at 13:37, Mathias Müller matheo81@gmail.com wrote:

Making it optional in game settings is of course the best solution.

On Sun, 31 Jan 2021 at 13:36, Mathias Müller matheo81@gmail.com wrote:

this:

https://www.youtube.com/watch?v=RKvMDNsEc14

On Sun, 31 Jan 2021 at 13:13, Pyrdacor notifications@github.com wrote:

Hi there. Thanks for the suggestion.

If we add this, I would do so as an option which can be turned on or off. Unfortunately I don't know Grimrock. But I will have a look at it. ;)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Pyrdacor/Ambermoon.net/issues/62#issuecomment-770372830, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASPM6H3GCZXUSGD4JPJCBCDS4VCPFANCNFSM4UVDOYQA .

Pyrdacor commented 3 years ago

Hey. Which Issue on Ambermoon.net is best to just dump testing observations in? On Sun, 31 Jan 2021 at 13:37, Mathias Müller @.> wrote: Making it optional in game settings is of course the best solution. On Sun, 31 Jan 2021 at 13:36, Mathias Müller @.> wrote: > this: > > https://www.youtube.com/watch?v=RKvMDNsEc14 > > On Sun, 31 Jan 2021 at 13:13, Pyrdacor @.***> wrote: > >> Hi there. Thanks for the suggestion. >> >> If we add this, I would do so as an option which can be turned on or >> off. Unfortunately I don't know Grimrock. But I will have a look at it. ;) >> >> — >> You are receiving this because you commented. >> Reply to this email directly, view it on GitHub >> <#62 (comment)>, >> or unsubscribe >> https://github.com/notifications/unsubscribe-auth/ASPM6H3GCZXUSGD4JPJCBCDS4VCPFANCNFSM4UVDOYQA >> . >> >

I guess #54 would be a good place. I dumped some things there too.

Shinhobi commented 3 years ago

Cool, I will probably bring it up there.

On Sun, 31 Jan 2021 at 15:17, Pyrdacor notifications@github.com wrote:

Hey. Which Issue on Ambermoon.net is best to just dump testing observations in? … <#m-2220586771528569476> On Sun, 31 Jan 2021 at 13:37, Mathias Müller @.> wrote: Making it optional in game settings is of course the best solution. On Sun, 31 Jan 2021 at 13:36, Mathias Müller @.> wrote: > this: > > https://www.youtube.com/watch?v=RKvMDNsEc14 > > On Sun, 31 Jan 2021 at 13:13, Pyrdacor @.***> wrote: > >> Hi there. Thanks for the suggestion.

If we add this, I would do so as an option which can be turned on or off. Unfortunately I don't know Grimrock. But I will have a look at it. ;) >> >> — >> You are receiving this because you commented. >> Reply to this email directly, view it on GitHub >> <#62 (comment) https://github.com/Pyrdacor/Ambermoon.net/issues/62#issuecomment-770372830>, or unsubscribe >> https://github.com/notifications/unsubscribe-auth/ASPM6H3GCZXUSGD4JPJCBCDS4VCPFANCNFSM4UVDOYQA . >> >

I guess #54 https://github.com/Pyrdacor/Ambermoon.net/issues/54 would be a good place. I dumped some things there too.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Pyrdacor/Ambermoon.net/issues/62#issuecomment-770389231, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASPM6H3LHG2RWTFMDVVEWCLS4VRAPANCNFSM4UVDOYQA .

kermitfrog commented 3 years ago

@Shinhobi Hi, and welcome to the project :) If you feel up to handling a few simple debugger commands, there are a few skill checks (search and probably some kind of trap) where it's unclear when they are used... I have compiled a quick guide on how to do it here: #70

As for the "Grimrock"-movement: I had something like that in mind when holding down a modifier. Also, if the project can ever run Amberstar as well, it might make implementing monster movement (which only happens when ingame time has passed) easier.

Pyrdacor commented 3 years ago

I updated the initial post to reflect current state.

About the grimrock movement or movement to full tiles. Can someone just create a feature request issue please? I will add this as an additional feature after first release at some point.

kermitfrog commented 3 years ago

Had another quick look at 0.9.3b.

kermitfrog commented 3 years ago

A few (new?) issues, mostly with the numpad:

kermitfrog commented 3 years ago

[..] Even a very short press will move the player by 2, sometimes 3 squares [..]

I did a quick test to look if this has something to do with key repeat events, but that is not the case - it's the same even if there are none. (I can simulate these detail with my own software inputmangler)

Pyrdacor commented 3 years ago

@kermitfrog I did a few improvements and fixes to the movement buttons (numpad keys). Can you check again with current TestRelease?

kermitfrog commented 2 years ago

I did a few improvements and fixes to the movement buttons (numpad keys). Can you check again with current TestRelease?

Damn, I totally missed that comment.. No, the moving-too-much-with-keypad-issue is still present in 1.1

I'll add several more UI related stuff to the list soon. Is it better to make a new comment, or should I update list in the first one?

Pyrdacor commented 2 years ago

As I still use this to track some things to add, it would be good to update the first post and remove things that are already added as well.

Pyrdacor commented 2 years ago

But maybe write a comment when you've done it, so I'll get a notification.

kermitfrog commented 2 years ago

Ok, I cleaned up and extended the task list.

I also noticed that the dialog words list seems to be sorted in order of occurrence now. Is that intentional?

kermitfrog commented 2 years ago

Added one more:

By which I mean: when looking at a sign in 3D you have to look very closely and in quite straight angle. However it does not always happen. Yesterday I had that problem many times, but could not reproduce it today. I'll write more when I have an idea about the circumstances

Pyrdacor commented 2 years ago

I also noticed that the dialog words list seems to be sorted in order of occurrence now. Is that intentional?

No, but it is already fixed in code.

Pyrdacor commented 2 years ago

Ok I converted some points to new issues that I definitely add in 1.3. The rest may still be added as well but I have to check them later dependent on time and priorities.