search

PyroFire232 / warptorio2

An updated / refined version of warptorio https://mods.factorio.com/mod/warptorio
8 stars 8 forks source link

Crash when played with Bob's Mods/Artisanal Reskins #22

Open kirazy opened 1 week ago

kirazy commented 1 week ago

image

The issue is here: https://github.com/PyroFire232/warptorio2/blob/5d875fa4ddf9f8280678409d7ff3412b000159fc/prototypes-updates/data_accumulators.lua#L152

When you copy the accumulator item prototype and then change the icon, you do not specify icon_size as part of your new IconData definition. Since Artisanal Reskins modifies the accumulator item prior to your copy operation, the icon_size at the item root is not present, and must be specified by your icons definition.

The fix is easy:

item.icons={{icon="__base__/graphics/icons/accumulator.png",icon_size=64,icon_mipmaps=4,tint=rtint}}
kirazy commented 1 week ago

While you're in there, I'd also suggest including icon_mipmaps in the merge operation above: https://github.com/PyroFire232/warptorio2/blob/5d875fa4ddf9f8280678409d7ff3412b000159fc/prototypes-updates/data_accumulators.lua#L147

icons={{icon="__base__/graphics/icons/accumulator.png",tint=rtint,icon_size=64,icon_mipmaps=4}},