nus-se-bot
commented
4 months ago Team's Response
Detailed under planned enhancements
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Error message of add_student is not specific enough
It seems like two students cannot have the same email and student ID, so when adding a student with the same email or student ID and error is given. However, error message given is not specific and is the same for both scenarios, whether the error is in the student ID or email.
This will result in the user not being able to figure out what is wrong with the command they entered as they will not know what to fix.
Steps to reproduce:
- Enter "/add_student name/Zack2 id/A4234567Z email/zack@example.com tag/Student "
- Error "already exists in the address book!" is given
- Enter "/add_student name/Zack2 id/A4234567Z email/zack@example.com tag/Student "
- Same error is given
[original: nus-cs2103-AY2324S2/pe-interim#4749] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Detailed in planned enhancement.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
I first added
Dohn Joesimilar to the command provided in the UG:/add_student name/Dohn Joe email/johndoe@gmail.com id/A0123456AThen I tried adding a different student, but with duplicate email and all other fields are different:
/add_student name/Jane Doe email/johndoe@gmail.com id/A1023456BThe application nicely attempts to detect a duplicate:
However, the error message may be misleading and trick the person into thinking that the student already exists in their system.