Pyroxenium / Basalt

A UI Framework for CC:Tweaked
MIT License
189 stars 34 forks source link

docs: Latest 1.7 docs suggests their is a `Basalt.setTheme()` #54

Closed ajh123 closed 1 year ago

ajh123 commented 1 year ago

Where? https://github.com/Pyroxenium/Basalt/blame/d4c72514ef560af88c7f7557ba6f35ddaa2dc724/docs/objects/Basalt.md#LL29C45-L29C45

As the title says, the docs contain a Basalt.setTheme() function which appears to no longer exist. When I load Basalt and run the Basalt.setTheme() from the Lua prompt (or any other file) I get the following error (even if I pass a correct table): basalt_error

Possible solutions

  1. Remove the function from the docs.
  2. Update the docs to contain the new alternative.
  3. Resurrect the old setTheme() function.

Others I have downloaded the recent Minified/Packed Version a few minutes ago.

Checklist [ X ] I am looking at the latest version of the docs.

NoryiE commented 1 year ago

Hello and thank you! I made a small mistake in my code which made setTheme and getTheme not public. Also fixed a small bug when using themes. This is fixed here: 6c235b0

ajh123 commented 1 year ago

Yes, that worked now.