Describe at a high level the solution you're providing
Using build args at docker build time to insert WEBSOCKET_URL into the dockerfile.
[x] added a placeholder PYRRHA_WS_URL in Dockerfile
[x] replace this placeholder with GitHub secret value using sed when the action is run
Note: as the URL is inserted at build time, anybody who has access to this built image will be able to see the URL using docker history. Currently we use private ICR registry to store the image, and so this should not be an issue. In any case the URL is also visible in the js file that comes out of yarn build. We can look at options to minify perhaps.
Ideally, the call-for-code/build-push-deploy@main action would accept build args, but it does not in it's current form.
Describe at a high level the solution you're providing Using build args at docker build time to insert WEBSOCKET_URL into the dockerfile.
PYRRHA_WS_URLin Dockerfilesedwhen the action is runNote: as the URL is inserted at build time, anybody who has access to this built image will be able to see the URL using
docker history. Currently we use private ICR registry to store the image, and so this should not be an issue. In any case the URL is also visible in the js file that comes out ofyarn build. We can look at options to minify perhaps.Ideally, the
call-for-code/build-push-deploy@mainaction would accept build args, but it does not in it's current form.@hawk4031 pls review. Thank you!