Issues to address for v3 expanded test

krook commented 3 years ago

[x] Abstract the notification time settings
[ ] Consistently use UTC in all displays (chart is currently local)
[ ] Make the x axis reflect time average over the full period (#62)
[x] Make the y limit the red threshold, or the blue line that's currently over it
[ ] Make change/update indicators more prominent (debug CSS animation fade in)
[ ] Error handle missing data or broken websocket
[x] Look into the date parsing difference between Chrome and Safari
[x] Ensure mobile display responsiveness, particularly on iPad
[ ] Update main dashboard to show overall red/yellow/green for each gas currently in danger (in any time-window) (ppt_1)
[x] Remove the graph on the default detail now view (it's the 10 min avg one) (ppt_2)
[x] Add a new live tab on the details page, remove it from the time views (ppt_3)
[x] Update the chart to be a line chart rather than area chart(ppt_4)
[x] Add chart to the Latest tab on the firefighter's page (i.e. history of sensor readings) (ppt_5)
[ ] Add labels to the chart lines on firefighter pages (e.g. 10 min limit, 10 min avg, probably don't need to label the yellow line) (ppt_6)
[ ] Enlarge the clickable area on the Red / Yellow / Green icons on the homepage and FF pages (ppt_9)
[x] Make authorization a configuration flag
[ ] Have the timestamp local reflect the i18n local storage language (needs to be set explicitly now)
[x] Add a tooltip over the datapoints in the chart

JSegrave-IBM commented 3 years ago

Added a few new ones - I'll slack you pics/slides for these:

Enlarge the clickable area on the Red / Yellow / Green icons on the homepage and FF pages (ppt_9)
Add chart to the Latest tab on the firefighter’s page (i.e. history of sensor readings) (ppt_5)
Add labels to the chart lines on firefighter pages (e.g. 10 min limit, 10 min avg, probably don’t need to label the yellow line) (ppt_6)

Changed this one

FROM Update main dashboard to show if any of the past readings are in danger, if not the live one
TO Update main dashboard to show overall red/yellow/green for each gas currently in danger (in any time-window) (ppt_1) I hope this is OK - it's to reflect that there's no 'past danger', per-se - all of the gases and all of averaging periods are 'live' all the time. (i.e. they're all about what's likely to be present in a FF's body 'live' right now - either from a short-sharp-shock that's only just happened or from accumulation over a longer time)

Updated this one:

Make the x axis reflect time average over the full period (#62) I added a note to #62. It's a change of mind from what I suggested on Tues, but I think probably better UX and simpler to implement.

krook commented 3 years ago

@pedrocruzio these are the two bugs it would be great for you to look at:

[ ] Consistently use UTC in all displays (chart is currently local)
[ ] Look into the date parsing difference between Chrome and Safari (iPad and mobile devices, including Android)

Key files to look at are the ones that drive the dashboard (home) and details (chart) pages:

Pyrrha-Platform / Pyrrha-Dashboard