dacamposol commented 3 years ago

Improve Dockerfile

Added the RedHat base image that contains way less vulnerabilities than the official one

Official	RedHat
13H 30M 133L	8H 0M 0L

Get advantage of the layered cache: it doesn't make sense to install the requirements each time that the code is modified. The requirements should be cached as a layer and only rebuild it when the requirements file is modified. This will improve a lot the times between consequent Docker builds, since from second build and onward only the three last layers need to be rebuilt (bulding time of 1.1s on average with 10 tries) if just code is changed.
Use the .env.docker file by default in the image if an .env file is not present in the repository. I saw there was a problem in #43 due to the lack of .env file meanwhile building and running the Docker image. This should fix the problem even if I agree a better README.md should be in place.

Fix #51

There's a known bug on APScheduler 3.6.3 due to it's dependency on tzlocal 3.0b1: agronholm/apscheduler#461

Solved with APScheduler 3.7.0 with no further changelog than bugfixing (already checked)

https://github.com/agronholm/apscheduler/compare/v3.6.3...v3.7.0

Is this a patch, a minor version change, or a major version change I would say that this could be considered a minor version change, but it's at the decision of the maintainers.

Is this related to an open issue?

51

42

krook commented 3 years ago

Wonderful, thank you @dacamposol. @upkarlidder @albertum1 FYI.

krook commented 3 years ago

And if you're inclined @dacamposol we have a weekly townhall meeting in about an hour... 2:30pm ET if you'd like to meet the community and introduce yourself.

Meeting details and recordings here: https://github.com/Pyrrha-Platform/Pyrrha#public-meetings Meeting notes here: https://github.com/Pyrrha-Platform/Pyrrha/wiki

demilolu commented 3 years ago

@dacamposol Thanks again for your contribution to our projects! I'm the Open Source Community Manager with Call for Code. We would like to invite you to join us for our Hacktoberfest Demo Day on October 29th where we'll be highlighting contributions. We'd like to have you give a quick demo of this PR and another one as part of the event if you're interested. Please let me know if you can make it! https://www.crowdcast.io/e/hacktoberfest-demo-day/register

dacamposol commented 3 years ago

@dacamposol Thanks again for your contribution to our projects! I'm the Open Source Community Manager with Call for Code. We would like to invite you to join us for our Hacktoberfest Demo Day on October 29th where we'll be highlighting contributions. We'd like to have you give a quick demo of this PR and another one as part of the event if you're interested. Please let me know if you can make it! https://www.crowdcast.io/e/hacktoberfest-demo-day/register

Yeah, sure! Count me in, I'll register when I'm at home.

demilolu commented 3 years ago

ok perfect! Can you join us in our Slack and let me know your Slack handle so I can add you. We're coordinating details. Here's the link to join: callforcode.org/slack @dacamposol

dacamposol commented 3 years ago

ok perfect! Can you join us in our Slack and let me know your Slack handle so I can add you. We're coordinating details. Here's the link to join: callforcode.org/slack @dacamposol

I just joined.

My display name is the same than the one I have in GitHub: @dacamposol

Pyrrha-Platform / Pyrrha-Rules-Decision

Improve Docker image #54

Improve Dockerfile

Fix #51

51

42