Pythe1337N / garmin-connect

Makes it simple to interface with Garmin Connect to get or set any data point.
MIT License
144 stars 58 forks source link

Attempt to fix CFClient blob downloads #25

Closed smaudet closed 2 years ago

smaudet commented 2 years ago

Did a couple lint fixes, this doesn't include certain elements of @primozs code one because I didn't write mine like that two because it presupposes newer versions of nodejs which everyone may not be using...

If you don't want the extra lint fixes, that's fine - there are still lint problems in the code base according your lint file/my lint parser.

smaudet commented 2 years ago

Also please note that there are no tests, I copied existing, previously working code, but I have no guarantee that it will work.

A Test Suite would be nice but there are obvious problems with setting up a test system e.g. the garmin server must be thoroughly mocked out...

I will try to install locally as a node package and run an existing client impl against this.