Closed CDillinger closed 2 years ago
Comment says Will default to 'zip'. Other possible values are 'tcx', 'gpx' or 'kml'.
Can you just give it a try for all file types and then i can do the merge. Just want to make sure it's the same for every case. Otherwise we need to support both.
I guess changing the regex to filename="?([^"]+)"?
would cover both cases in one go.
zip
is indeed broken on my changes, but all the other formats work:
Your proposed regex works as expected for all formats:
I will update the PR. Thank you!
When trying to download a TCX file, I was facing errors like this:
and the stack trace pointed to this line.
I logged the response here and found this header did not include quotes for the activities from my account. Example observed header value:
I removed the quotes on this line and the TCX download began working as expected.
Thank you for creating this library!