Add optional untyped/type parameters to getActivities method

Pythe1337N / garmin-connect

Makes it simple to interface with Garmin Connect to get or set any data point.

MIT License

144 stars 58 forks source link

Add optional untyped/type parameters to getActivities method #66

Open dachia opened 10 months ago

dachia commented 10 months ago

Hi, @Pythe1337N

underlying getActivities API can support multiple filters, besides offset or limit. For example, very useful parameters are startDate and endDate, activityType.

I propose that, if possible and make sense, add an optional hashmap parameter to the getActivities call and insert those into request params.

Thank you for all your time and effort!

P.S. If you would prefer it, I can create PR for this

gregegan commented 9 months ago

This makes sense to me, can you put up a PR for this @dachia?

@dachia where are you able to find the docs of all the filters that are supported by each endpoint?

gregegan commented 8 months ago

Mark as resolved @Pythe1337N https://github.com/Pythe1337N/garmin-connect/pull/73/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L183