Python-Cardano / pycardano

A lightweight Cardano library in Python
https://pycardano.readthedocs.io
MIT License
215 stars 67 forks source link

Fix ogmios v6 backend / plutusv3 #383

Closed nielstron closed 1 week ago

nielstron commented 1 week ago

Attempts to resolve #381 as proposed by @nullhashpixel

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.30%. Comparing base (3ca745a) to head (4a6b697). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pycardano/backend/ogmios_v6.py 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #383 +/- ## ========================================== + Coverage 85.23% 85.30% +0.07% ========================================== Files 32 32 Lines 4213 4213 Branches 1060 1060 ========================================== + Hits 3591 3594 +3 + Misses 435 434 -1 + Partials 187 185 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cffls commented 1 week ago

Seems like the integration test has failed with errors like this:

FAILED test/test_plutus.py::TestPlutus::test_plutus_v2_inline_script_inline_datum - AttributeError: 'dict' object has no attribute 'language'
nielstron commented 1 week ago

It seems that the script object is a dict and not (like the typing suggests) a Script object @wrmarchetto