search

Python-Cardano / pycardano

A lightweight Cardano library in Python
https://pycardano.readthedocs.io
MIT License
215 stars 67 forks source link

Methods to add certificate scripts for smart staking #388

Open SCMusson opened 5 days ago

SCMusson commented 5 days ago

Following on from #387 and #378, this should add support for staking with staking scripts.

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.96%. Comparing base (3034cd9) to head (bed9167). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pycardano/txbuilder.py 11.11% 15 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #388 +/- ## ========================================== - Coverage 85.30% 84.96% -0.34% ========================================== Files 32 32 Lines 4213 4231 +18 Branches 1060 1065 +5 ========================================== + Hits 3594 3595 +1 - Misses 434 449 +15 - Partials 185 187 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nielstron commented 5 days ago

There are some QA issues, make sure to run make qa and fix the remaining errors :)


poetry run flake8 pycardano
pycardano/txbuilder.py:161:1: W293 blank line contains whitespace
pycardano/txbuilder.py:399:121: E501 line too long (131 > 120 characters)
pycardano/txbuilder.py:416:121: E501 line too long (196 > 120 characters)
pycardano/txbuilder.py:519:1: W293 blank line contains whitespace
make: *** [Makefile:64: qa] Error 1
SCMusson commented 5 days ago

Apologies, I should have read the development section more thoroughly.

nielstron commented 5 days ago

No worries, I did the exact same in my first (few) PRs

nielstron commented 5 days ago

We seem to have run into a docker limitation with the CI. @cffls do you know anything about this? Maybe just need to wait a day and retry