search

Python-Dojo / Dojo-Helper-App

Place for people to complete bounties supplied by Ray in The Python Dojo discord channel.
MIT License
2 stars 1 forks source link

Run a formatter on pull request. #13

Closed JustCallMeRay closed 1 year ago

JustCallMeRay commented 1 year ago

Have a formatter do a "dry run" (make no changes to the code but show up as a failed pipeline if a file requires formatting.

Have a linter do a dry run and fail the pipeline if any file requires changing

fungss commented 1 year ago

Hi @JustCallMeRay, I've finished the tasks and have created a pull request. Please have a look. Thanks!

JustCallMeRay commented 1 year ago

Hiya, done a review, looks good but requires some small changes

fungss commented 1 year ago

Have made the changes accordingly. Please have a look again. Thanks : ]