Python-Dojo / Dojo-Helper-App

Place for people to complete bounties supplied by Ray in The Python Dojo discord channel.
MIT License
2 stars 1 forks source link

Code coverage CI #15

Closed GeeCastro closed 1 year ago

GeeCastro commented 1 year ago

5

This adds code coverage to the CI pipeline.

JustCallMeRay commented 1 year ago

Hiya, let me know when you are available and we can go through this over the discord instead of with messages (people tend to learn more.)

Before I review your code could you please do the following: Move the ticket into the correct swim lane (so no one else does the work you are doing) Please create a branch and merge your code into it (normally only third parties work on forks) If you could remove everything that isn't used in requirements.txt (I missed it during the last review) that would be really helpful. Create a merge request for that branch you created.

Between now and your code going into main I'd like to see it tested with act but installing docker can be pain so I'm just warning you now :).