search

Python-Markdown / markdown

A Python implementation of John Gruber’s Markdown with Extension support.
https://python-markdown.github.io/
BSD 3-Clause "New" or "Revised" License
3.79k stars 863 forks source link

Remove previously deprecated objects. #1260

Closed waylan closed 2 years ago

waylan commented 2 years ago

This completely removes all objects which were deprecated back on version 3.0. We are now working on 3.4 so I think perhaps we can move forward with this. The one hesitation I have is that it is possible some older (unmaintained) extensions could stop working. However, given the time that has passed, and the fact that those extensions probably don't even support the new minimum Python version, I expect this to mostly be a non-issue.

So far, I have only made changes to the code. I still need to add something to the release notes.

waylan commented 2 years ago

After having made these changes it occurs to me that we could perhaps have raised some sort of DeprecationError for a version before completely removing these objects. Any thoughts?

mitya57 commented 2 years ago

After having made these changes it occurs to me that we could perhaps have raised some sort of DeprecationError for a version before completely removing these objects. Any thoughts?

You mean one intermediate step between DeprecationWarning and complete removal? I don't see any sense, warnings are quite visible and I don't remember any other projects doing this. Some projects have distinct PendingDeprecationWarning and DeprecationWarning, though.