search

Python-World / python-mini-projects

A collection of simple python mini projects to enhance your python skills
https://python-world.github.io/python-mini-projects/#/
MIT License
15k stars 4.89k forks source link

Several README.md submissions display the wrong author #381

Closed tripleee closed 4 years ago

tripleee commented 4 years ago

Description

README.md should display the author of the project, not the author of the README.

Type of issue

Checklist:

tripleee commented 4 years ago

382 now fixes this for Store_emails_in_csv but the whole list of project authors should be reviewed against the README files in each.

tripleee commented 4 years ago

Why was this closed? Many of these indicate the wrong author, compared to what's already listed in the main project README. 

tripleee$ awk 'tolower($0) ~ /author/ { a=1; next } /<!--/ { next } /^[ \t]*$/ { next }
> a { print FILENAME, $0 ; a=0; nextfile }' projects/*/README.md
projects/All_links_from_given_webpage/README.md Kai Reichart
projects/Calculate_age/README.md random1001guy
projects/Convert_XML_To_JSON/README.md Azhad Ghufran
projects/Convert_a_image_to_pdf/README.md Devansh Agarwal
projects/Convert_numbers_to_word/README.md Niraj Shrestha
projects/Create_calculator_app/README.md [Fin McCallum](https://github.com/FinMc)
projects/Currency_converter/README.md [Fin McCallum](https://github.com/FinMc)
projects/Decimal_to_binary_convertor_and_vice_versa/README.md [Fin McCallum](https://github.com/FinMc)
projects/Dominant_color/README.md Himanshu Hansaria
projects/Duplicate files remover/README.md Anandha Krishnan Aji
projects/EasyVideoPlayer/README.md   Bartu Yaman
projects/Encrypt_and_decrypt_text/README.md [Gaodong](https://github.com/xlgd)
projects/Fetch_and_store_tweets/README.md [AnilKumarTeegala](https://github.com/AnilKumarTeegala)
projects/Fetch_open_ports/README.md Aleksej Komnenovic
projects/Find_imdb_rating/README.md <a href = "https://github.com/utkarshbajaj"> Utkarsh Bajaj </a>
projects/Find_out_hostname_and_ip_address/README.md Nuh Mohammed
projects/Hello/README.md Ravi Chavare
projects/Image_watermark/README.md Devansh Agarwal
projects/Internet_connection_check/README.md [Ashu Sharma](https://github.com/AshuSharma7)
projects/Language_translator/README.md Azhad Ghufran
projects/Leap_Year_Checker/README.md [Hariom1509](https://github.com/Hariom1509)
projects/Merge_pdfs/README.md ShivSt
projects/Movie Information Scraper/README.md Anandha Krishnan Aji
projects/Number_guessing_game/README.md [Javokhir](https://github.com/leader2one/)
projects/Recursive_password_generator/README.md Erfan Saberi
projects/Reduce_image_file_size/README.md ### *Vipul Verma*
projects/Scrape_Hacker_News/README.md Developed by Javokhir
projects/Scrape_quotes/README.md Anandha Krishnan Aji
projects/Scraping Medium Articles/README.md [Naman Shah](https://github.com/namanshah01)
projects/Set_Alarm/README.md [Kai Reichart](https://github.com/KaiReichart)
projects/Shutdown_or_restart_your_device/README.md Hannah Machado 
projects/Speech_to_text/README.md Devansh Agarwal
projects/Spell_checker/README.md [Hariom1509](https://github.com/Hariom1509)
projects/Split_File/README.md Kanishk Gupta
projects/Store_emails_in_csv/README.md Aditya Jetely (@AdityaJ7)
projects/String_search_from_multiple_files/README.md README: [Alex Munoz](https://github.com/AlexMunoz905)
projects/Terminal_Based_Hangman_Game/README.md Neoh Boon Yee
projects/Text_to_speech/README.md Simon Hanrath
projects/Tic_tac_toe/README.md 
projects/Tic_tac_toe_with_ai/README.md   - Tushar Nankani (tusharnankani, tusharnankani3@gmail.com)
projects/Unstructured Supplemenrary  Service Data/README.md Ajayi Raymond Tomisin (ART) 
projects/Web_scraping_a_youtube_comment/README.md - Azhad Ghufran
projects/Website_blocker/README.md [Kai Reichart](https://github.com/KaiReichart)
projects/Wikipedia_search_wordcloud/README.md [Naman Shah](https://github.com/namanshah01)
projects/cli_proxy_tester/README.md This mini project is a proxy tester based on `requests`. It utilized `pandas` for handling csv files and
projects/convert pdf to text/README.md pi1814
projects/convert_Imgs/README.md Xordux
projects/convert_dictionary_to_python_object/README.md Xordux
projects/download GeeksForGeeks articles/README.md [Shiv Thakur](https://github.com/ShivSt)

In the main README,

I could go on but this should hopefully at least convince you that this is not yet fixed.

AdityaJ7 commented 4 years ago

Why was this closed? Many of these indicate the wrong author, compared to what's already listed in the main project README.

tripleee$ awk 'tolower($0) ~ /author/ { a=1; next } /<!--/ { next } /^[ \t]*$/ { next }
> a { print FILENAME, $0 ; a=0; nextfile }' projects/*/README.md
projects/All_links_from_given_webpage/README.md Kai Reichart
projects/Calculate_age/README.md random1001guy
projects/Convert_XML_To_JSON/README.md Azhad Ghufran
projects/Convert_a_image_to_pdf/README.md Devansh Agarwal
projects/Convert_numbers_to_word/README.md Niraj Shrestha
projects/Create_calculator_app/README.md [Fin McCallum](https://github.com/FinMc)
projects/Currency_converter/README.md [Fin McCallum](https://github.com/FinMc)
projects/Decimal_to_binary_convertor_and_vice_versa/README.md [Fin McCallum](https://github.com/FinMc)
projects/Dominant_color/README.md Himanshu Hansaria
projects/Duplicate files remover/README.md Anandha Krishnan Aji
projects/EasyVideoPlayer/README.md   Bartu Yaman
projects/Encrypt_and_decrypt_text/README.md [Gaodong](https://github.com/xlgd)
projects/Fetch_and_store_tweets/README.md [AnilKumarTeegala](https://github.com/AnilKumarTeegala)
projects/Fetch_open_ports/README.md Aleksej Komnenovic
projects/Find_imdb_rating/README.md <a href = "https://github.com/utkarshbajaj"> Utkarsh Bajaj </a>
projects/Find_out_hostname_and_ip_address/README.md Nuh Mohammed
projects/Hello/README.md Ravi Chavare
projects/Image_watermark/README.md Devansh Agarwal
projects/Internet_connection_check/README.md [Ashu Sharma](https://github.com/AshuSharma7)
projects/Language_translator/README.md Azhad Ghufran
projects/Leap_Year_Checker/README.md [Hariom1509](https://github.com/Hariom1509)
projects/Merge_pdfs/README.md ShivSt
projects/Movie Information Scraper/README.md Anandha Krishnan Aji
projects/Number_guessing_game/README.md [Javokhir](https://github.com/leader2one/)
projects/Recursive_password_generator/README.md Erfan Saberi
projects/Reduce_image_file_size/README.md ### *Vipul Verma*
projects/Scrape_Hacker_News/README.md Developed by Javokhir
projects/Scrape_quotes/README.md Anandha Krishnan Aji
projects/Scraping Medium Articles/README.md [Naman Shah](https://github.com/namanshah01)
projects/Set_Alarm/README.md [Kai Reichart](https://github.com/KaiReichart)
projects/Shutdown_or_restart_your_device/README.md Hannah Machado 
projects/Speech_to_text/README.md Devansh Agarwal
projects/Spell_checker/README.md [Hariom1509](https://github.com/Hariom1509)
projects/Split_File/README.md Kanishk Gupta
projects/Store_emails_in_csv/README.md Aditya Jetely (@AdityaJ7)
projects/String_search_from_multiple_files/README.md README: [Alex Munoz](https://github.com/AlexMunoz905)
projects/Terminal_Based_Hangman_Game/README.md Neoh Boon Yee
projects/Text_to_speech/README.md Simon Hanrath
projects/Tic_tac_toe/README.md 
projects/Tic_tac_toe_with_ai/README.md   - Tushar Nankani (tusharnankani, tusharnankani3@gmail.com)
projects/Unstructured Supplemenrary  Service Data/README.md Ajayi Raymond Tomisin (ART) 
projects/Web_scraping_a_youtube_comment/README.md - Azhad Ghufran
projects/Website_blocker/README.md [Kai Reichart](https://github.com/KaiReichart)
projects/Wikipedia_search_wordcloud/README.md [Naman Shah](https://github.com/namanshah01)
projects/cli_proxy_tester/README.md This mini project is a proxy tester based on `requests`. It utilized `pandas` for handling csv files and
projects/convert pdf to text/README.md pi1814
projects/convert_Imgs/README.md Xordux
projects/convert_dictionary_to_python_object/README.md Xordux
projects/download GeeksForGeeks articles/README.md [Shiv Thakur](https://github.com/ShivSt)

In the main README,

I could go on but this should hopefully at least convince you that this is not yet fixed.

Yeah I know it is not fixed, but the thing is some of the people didn't mention their names when they added the scripts/projects and after that, some people who created readme files for the projects added their names as author instead of the original project creators , so this author area is a bit messy.

AdityaJ7 commented 4 years ago

I can reopen this issue for you if you want to fix these names but most of them won't match the readme-files because earlier this repo didn't have readme files with individual scripts.

tripleee commented 4 years ago

Please do. I don't know when I can get to it, but to me, closing indicates either that there is no intent to fix the problem (in which case tag as wontfix) or that it was fixed already. Or that the problem doesn't exist.