Closed KhyalKara closed 3 years ago
The script python-password-generator.py uses random.sample to pick unique characters, without allowing repetition of characters.
In short the number of possible passwords is greatly reduced
Proposed Fix:
# Instead Use: random.choices(total, k=length)
[x] Bug
[x] I have read the project guidelines.
[x] I have checked all the existing projects, before submitting a new project issue.
[x] I have checked previous issues to avoid duplicates.
[x] This issue will be meaningful for the project.
[x] I have added screenshots of the bug
[x] I have added steps to reproduce the bug
[x] I have proposed a possible solution for the bug
Description
The script python-password-generator.py uses random.sample to pick unique characters, without allowing repetition of characters.
In short the number of possible passwords is greatly reduced
Proposed Fix:
Type of issue
[x] Bug
Checklist:
[x] I have read the project guidelines.
[x] I have checked all the existing projects, before submitting a new project issue.
[x] I have checked previous issues to avoid duplicates.
[x] This issue will be meaningful for the project.
[x] I have added screenshots of the bug
[x] I have added steps to reproduce the bug
[x] I have proposed a possible solution for the bug