search

PythonBulawayo / ChitChat

22 stars 24 forks source link

Create GitHub Action for linting Back End code #27

Closed terrameijar closed 6 months ago

terrameijar commented 7 months ago

@Nolulamo mentioned that she'll be taking this one on.

ChikangaTakudzwa commented 6 months ago

is it possible to assign the people working on issues on the issues

ChikangaTakudzwa commented 6 months ago

i will make an action and create a pull request, but does it have to pass in my fork or when merged people will have to fix their code to make the lint pass

terrameijar commented 6 months ago

@ChikangaTakudzwa GitHub doesn't allow me to assign issues until 1) you comment on an issue or 2) you're added to the GitHub organisation for the project. I will add you to the org now.

The lint check will fail because we haven't linted and formatted the code yet. We want it to fail so we identify where to fix, address the issues and make it pass.

terrameijar commented 6 months ago

This was resolved in https://github.com/PythonBulawayo/ChitChat/pull/45