galzunited commented 3 years ago

https://forums.pythonic.guru/t/topic/8637

Added an option for user to import holidays from ics file. Took the naïve approach for now - not checking for duplicates while importing. Need to think about this mechanism - since checking every date to see if holiday is there is too expensive. As for the first step i think its ok (:

codecov-io commented 3 years ago

Codecov Report

Merging #165 (b712b4b) into develop (dfd34f3) will decrease coverage by 0.35%. The diff coverage is 82.60%.

@@             Coverage Diff             @@
##           develop     #165      +/-   ##
===========================================
- Coverage    99.38%   99.02%   -0.36%     
===========================================
  Files           46       46              
  Lines         2101     2146      +45     
===========================================
+ Hits          2088     2125      +37     
- Misses          13       21       +8

Impacted Files	Coverage Δ
app/routers/profile.py	`93.84% <82.60%> (-6.16%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfd34f3...b712b4b. Read the comment docs.

galzunited commented 3 years ago

Hi @yammesicka - just found out that in latest version I'm having weird issues - when trying to add the file and import I'm getting: "Did not find CR at end of boundary (40)" While trying to import using postman everything works fine (and it also worked locally when originally pushed). Tried to look for answers without success, might relate to multipart, but in django it seems we are using to correct enctype for the form.

Edit - found the solution - i pushed it to extending_openapi as this branch already been marged

PythonFreeCourse / calendar

feat: adding holidays to calendar as events #165

Codecov Report