PythonFreeCourse / calendar

Apache License 2.0
34 stars 52 forks source link

add: javascript snippet "voice.js" and accordingly update "edit_event… #178

Closed nir9696 closed 3 years ago

nir9696 commented 3 years ago

There is a recurring problem with "datetime" detection in event.py. At first I saw the source of the error - using the "dt" alias, but now there is no such alias, so the error is not clear to me. I saw that others also encountered this error. Can you please take a look?

yammesicka commented 3 years ago

There is a recurring problem with "datetime" detection in event.py. At first I saw the source of the error - using the "dt" alias, but now there is no such alias, so the error is not clear to me. I saw that others also encountered this error. Can you please take a look?

Try to pull from develop, I believe

codecov-io commented 3 years ago

Codecov Report

Merging #178 (49a77b6) into develop (8cd3a6e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #178   +/-   ##
========================================
  Coverage    99.04%   99.04%           
========================================
  Files           52       52           
  Lines         2409     2409           
========================================
  Hits          2386     2386           
  Misses          23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8cd3a6e...49a77b6. Read the comment docs.

OdeYec commented 3 years ago

Hi, some hindsight notes: notice that in edit_event_details_tab.html you are using multiple id tags with the same values that is bad practice (there should be only one element with the same id tag per page) + you have div elements without closing tags which breaks the layout.