search

PythonFreeCourse / calendar

Apache License 2.0
34 stars 52 forks source link

Add_UI_Test/Cypress/Basic_tests #190

Open Lisafiluz opened 3 years ago

yammesicka commented 3 years ago

Are cypress/support and cypress/plugins necessary?

Lisafiluz commented 3 years ago

cypress/support handles all the logic of the commands (functions to doings things in the UI) and services (functions to doings things with requests - directly to the server)

cypress/plugins in not necessary for now, but I'll continue to write tests when the most of the UI functionality will merge to dev so if it never be used I'll delete it.

Gonzom commented 3 years ago

Hey, another point which is worth fixing is the file names. The Google JavaScript Style Guide says:

File names must be all lowercase and may include underscores (_) or dashes (-), but no additional punctuation. Follow the convention that your project uses.

So your files such as "ProfilePage/cy_User_Card_Actions.js" should be renamed and I'd say to lowercase, to match our *.py files.

codecov-io commented 3 years ago

Codecov Report

Merging #190 (7dbe7af) into develop (b91708d) will increase coverage by 4.21%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
+ Coverage    95.15%   99.36%   +4.21%     
===========================================
  Files           76       36      -40     
  Lines         3382     1418    -1964     
===========================================
- Hits          3218     1409    -1809     
+ Misses         164        9     -155
Impacted Files Coverage Δ
app/database/database.py 100.00% <ø> (ø)
app/database/models.py 95.83% <0.00%> (-1.31%) :arrow_down:
app/dependencies.py 100.00% <0.00%> (ø)
app/telegram/bot.py 100.00% <0.00%> (ø)
app/routers/email.py 100.00% <0.00%> (ø)
app/internal/email.py 100.00% <0.00%> (ø)
app/routers/agenda.py 100.00% <0.00%> (ø)
app/routers/export.py 100.00% <0.00%> (ø)
app/routers/search.py 100.00% <0.00%> (ø)
app/internal/search.py 100.00% <0.00%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b91708d...b8cd8d3. Read the comment docs.

Lisafiluz commented 3 years ago

Conflicts fixed