search

PythonFreeCourse / calendar

Apache License 2.0
34 stars 52 forks source link

Feature/login #195

Closed kobyfogel closed 3 years ago

kobyfogel commented 3 years ago

This is my version for users management system: register, login, and current logged-in user. This version doesn't use fast-api_users library. My comment to 1 CR was not answered, so it's not 'resolved' yet. Instructions for using security dependencies are given in README.md file.

codecov-io commented 3 years ago

Codecov Report

Merging #195 (e5f235b) into develop (856c843) will increase coverage by 0.00%. The diff coverage is 98.67%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #195    +/-   ##
=========================================
  Coverage    99.06%   99.07%            
=========================================
  Files           48       55     +7     
  Lines         2251     2478   +227     
=========================================
+ Hits          2230     2455   +225     
- Misses          21       23     +2
Impacted Files Coverage Δ
app/internal/security/ouath2.py 96.00% <96.00%> (ø)
app/routers/login.py 96.87% <96.87%> (ø)
app/database/models.py 96.68% <100.00%> (+0.06%) :arrow_up:
app/database/schemas.py 100.00% <100.00%> (ø)
app/internal/security/dependancies.py 100.00% <100.00%> (ø)
app/internal/security/schema.py 100.00% <100.00%> (ø)
app/main.py 100.00% <100.00%> (+3.44%) :arrow_up:
app/routers/logout.py 100.00% <100.00%> (ø)
app/routers/register.py 100.00% <100.00%> (ø)
app/routers/salary/config.py 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 856c843...7d5395c. Read the comment docs.

kobyfogel commented 3 years ago

If i clicked on 'resoved' on an issue, without addressing it, it was just by mistake. In few of the cases, i just thought that the CR is for another line of code, and i thought i did resolve it.

kobyfogel commented 3 years ago

I tried to answer the best i can, hopefully it clarifies everything that was not understood. I also tried to fix what i could, and i hope that will be good enough.