search

PythonFreeCourse / calendar

Apache License 2.0
34 stars 52 forks source link

add: world_clock.py and test_world_clock.py #222

Open nir9696 opened 3 years ago

nir9696 commented 3 years ago

Hi :) Can you please response to the 2 comments I wrote above?

codecov-io commented 3 years ago

Codecov Report

Merging #222 (4273a6c) into develop (b5f0545) will decrease coverage by 3.83%. The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #222      +/-   ##
===========================================
- Coverage    99.38%   95.54%   -3.84%     
===========================================
  Files           37       80      +43     
  Lines         1456     3727    +2271     
===========================================
+ Hits          1447     3561    +2114     
- Misses           9      166     +157
Impacted Files Coverage Δ
app/database/alembic/env.py 0.00% <0.00%> (ø)
app/internal/audio.py 28.94% <28.94%> (ø)
app/routers/audio.py 43.90% <43.90%> (ø)
app/routers/user.py 80.00% <68.42%> (-20.00%) :arrow_down:
app/routers/profile.py 92.79% <74.19%> (-7.21%) :arrow_down:
app/routers/weight.py 81.57% <81.57%> (ø)
app/routers/credits.py 85.71% <85.71%> (ø)
app/routers/four_o_four.py 85.71% <85.71%> (ø)
app/utils/extending_openapi.py 88.88% <88.88%> (ø)
app/internal/on_this_day_events.py 90.62% <90.62%> (ø)
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5f0545...7953228. Read the comment docs.

nir9696 commented 3 years ago
  1. I tried to use both async-lru, for the asynchronous function, and functools.lru_cache, for uploading the files, and many tests fail suddenly for RuntimeError: Event loop is closed and 174 Http Error errors. I tried everything and I am lost.
  2. Also, my code is after the prehook fixes, so I do not know what I have left to fix ...
yammesicka commented 3 years ago

There are few comments that aren't related to caching. Fix them and I'll consider this as a ticket :)