PythonFreeCourse / calendar

Apache License 2.0
34 stars 52 forks source link

Frontend Inheritance Organization - Day View Responsiveness Bug Fix #279

Closed OdeYec closed 3 years ago

OdeYec commented 3 years ago

Made some fixes and rearrangements to Day View to improve responsiveness

codecov-io commented 3 years ago

Codecov Report

Merging #279 (b5864b2) into develop (cff596e) will decrease coverage by 0.18%. The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #279      +/-   ##
===========================================
- Coverage    98.77%   98.58%   -0.19%     
===========================================
  Files           64       67       +3     
  Lines         2849     2898      +49     
===========================================
+ Hits          2814     2857      +43     
- Misses          35       41       +6     
Impacted Files Coverage Δ
app/routers/dayview.py 98.09% <81.81%> (-1.91%) :arrow_down:
app/database/models.py 96.66% <100.00%> (ø)
app/routers/event.py 98.04% <100.00%> (ø)
app/main.py 92.85% <0.00%> (ø)
app/routers/register.py 100.00% <0.00%> (ø)
app/routers/salary/config.py 100.00% <0.00%> (ø)
app/internal/security/ouath2.py 98.14% <0.00%> (ø)
app/routers/friendview.py 100.00% <0.00%> (ø)
app/internal/friend_view.py 91.66% <0.00%> (ø)
app/routers/credits.py 85.71% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cff596e...b5864b2. Read the comment docs.

OdeYec commented 3 years ago

Just a quick note that @sagizaidor fixed an issue and made a PR to my repo. Now that it's been fixed and merged, this PR is ready enough for merging into develop to allow others to develop upon these changes. @yammesicka