search

PythonNest / PyNest

PyNest is a Python framework built on top of FastAPI that follows the modular architecture of NestJS
https://pythonnest.github.io/PyNest
MIT License
737 stars 50 forks source link

Introducing Module Decorator for Enhanced IoC and Context Management #18

Closed danielmoumeny212 closed 5 months ago

danielmoumeny212 commented 11 months ago

This pull request introduces module declaration using the Module decorator, implements a basic Inversion of Control (IoC) system as a starting point, and establishes an application context for a Dependency Injection (DI) system.

ItayTheDar commented 9 months ago

@danielmoumeny212 Hi daniel! How are you? this is a true masterpiece and I would like us to have a small meeting to talk about your contribution if you mind?

danielmoumeny212 commented 9 months ago

Hi there! I appreciate your kind words. I'm doing well, thank you. I'd be happy to schedule a meeting to discuss my contribution. Please let me know a convenient time for you.

Le lun. 11 déc. 2023 à 10:53, Itay Dar @.***> a écrit :

@danielmoumeny212 https://github.com/danielmoumeny212 Hi daniel! How are you? this is a true masterpiece and I would like us to have a small meeting to talk about your contribution if you mind?

— Reply to this email directly, view it on GitHub https://github.com/PythonNest/PyNest/pull/18#issuecomment-1849703665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZR7MNKDCI43VO5ILIA22B3YI3J3NAVCNFSM6AAAAAA6TPXIDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBZG4YDGNRWGU . You are receiving this because you were mentioned.Message ID: @.***>

pisipisi commented 9 months ago

I definitely need this PR, thanks so much for your great work @danielmoumeny212

danielmoumeny212 commented 9 months ago

@pisipisi I'm glad you like it! I've been eagerly awaiting the merge for a while now. Hopefully, it gets merged soon! You can check out the fork with the modifications on my GitHub profile

ItayTheDar commented 9 months ago

@pisipisi I'm glad you like it! I've been eagerly awaiting the merge for a while now. Hopefully, it gets merged soon! You can check out the fork with the modifications on my GitHub profile

@danielmoumeny212 I'm also can't wait for this pr to be merged, this will be a huge milestone for PyNest. could we schedule a meeting this week? maybe tomorrow at 16:00?

danielmoumeny212 commented 9 months ago

@ItayTheDar of course we can ! Absolutely!Tomorrow at 16:00 works for me.

Regarding the time zone, could you please confirm your current geographical location? This will help me ensure that 16:00 on your end aligns with my availability.

danielmoumeny212 commented 9 months ago

@ItayTheDar @pisipisi Here's the link to my playground project that allowed me to test the features proposed in the PR! Feel free to clone it and see how it works: https://github.com/danielmoumeny212/pynest_playground

ItayTheDar commented 9 months ago

@ItayTheDar of course we can ! Absolutely!Tomorrow at 16:00 works for me.

Regarding the time zone, could you please confirm your current geographical location? This will help me ensure that 16:00 on your end aligns with my availability.

Hi @danielmoumeny212! my timezone is GMT+2. I believe that you are from DRC? so you either in GMT+2 (Kinshasa) or GMT+1 (Lubumbashi)?

ItayTheDar commented 9 months ago

@ItayTheDar @pisipisi Here's the link to my playground project that allowed me to test the features proposed in the PR! Feel free to clone it and see how it works: https://github.com/danielmoumeny212/pynest_playground

This is super cool. I'm looking into it!

pisipisi commented 9 months ago

@danielmoumeny212 awesome! I will check it out.

danielmoumeny212 commented 9 months ago

@ItayTheDar Gmt + 1 from Congo Brazzaville not DRC !

danielmoumeny212 commented 9 months ago

Hey @ItayTheDar, have you checked out the pynest playground? If so, what are your thoughts on it?

ELC commented 6 months ago

Any updates on when this PR will get merged?

ItayTheDar commented 6 months ago

Hi @ELC! Sorry for the delay. This pr is missing some very important part of the DI mechanism which is the part of initialize the dependencies and store them in a dictionary. I'm working this days on adding this capability so pynest will offer an actual modular architecture.