search

PythonNut / company-flx

:city_sunset: Flx fuzzy matching for company
GNU General Public License v3.0
85 stars 6 forks source link

Fix issue reported by the byte-compiler #25

Closed tarsius closed 2 years ago

tarsius commented 2 years ago

Please see the commit messages for more information.

PythonNut commented 2 years ago

The switch to cl-labels appears correct. The reason I avoid requiring flx is due to lazy-loading. The warnings can be suppressed with declare-function instead, right?

tarsius commented 2 years ago

The reason I avoid requiring flx is due to lazy-loading.

I figured that much, but was left wondering why. flx.el itself should be loaded in a blink and while its only dependency, cl-lib, certainly takes a while, it is almost certain that some other package that is loaded during startup loads that anyway. To me this seems like an unnecessary and ineffective optimization, but I didn't benchmark it.

The warnings can be suppressed with declare-function instead, right?

Right. If you really want to go down that road, then I can do that.

tarsius commented 2 years ago

I've deleted my fork. I think in the past that did not cause pull-requests to be closed. I hope you can still reopen and merge this.