PythonPredictions / cobra

A Python package to build predictive linear and logistic regression models focused on performance and interpretation
https://pythonpredictions.github.io/cobra.io
MIT License
30 stars 6 forks source link

Change attribute naming in preprocessor #169

Closed patrickleonardy closed 1 year ago

patrickleonardy commented 1 year ago

Story Title

Preprocessor displaying bug #168

Changes made

Changed the naming of the attributes in the PreProcessor object as suggested in the BaseEstimator documentation

How does the solution address the problem

By changing the naming from _attribute to attribute. Like this they have the same name as the parameters in __init__. I know that they were supposed to be internal variables but it seems that the BaseEstimator class from which our PreProcessor inherits does not like this. I also could have also added a "_" before the parameter name of the parameters passed in the __init__ function but this seemed weird to me.

Linked issues

Resolves #168