search

PythonScanClient / PyScanClient

Python Client for CS-Studio Scan Service
Eclipse Public License 1.0
3 stars 4 forks source link

Set command: Add 'readback', remove 'wait' param #2

Closed kasemir closed 9 years ago

kasemir commented 9 years ago

Set command needs a way to configure the 'readback' as different from the primary device name. When doing that, the 'wait' can be made implicit, see https://github.com/kasemir/ScanClientSandbox/blob/master/scan_client/scan/commands/set.py and https://github.com/kasemir/ScanClientSandbox/blob/master/scan_client/test_commands.py

ksdj commented 9 years ago

I see.You code means that there is a implicit relation among 'timeout' ,'tolerance' and 'readback'. Should this relation also suitable for command 'Loop'?

kasemir commented 9 years ago

Yes. On the client side, when setting the 'readback', that results in enabling the "wait" for that "readback" to match the desired value within the "tolerance". The "timeout" applies to both the callback completion and the read back check.

For convenience, on the client side I would allow this for the read back parameter:

False means read back is not used. True means wait-for-readback is enabled, using the primary pv name. "SomePvName" means readback uses that pv name, not the primary pv name.

Yes, the loop command is the same in this regard.