Fix for RuntimeError('Event loop is closed')

PythonistaGuild / TwitchIO

An Async Bot/API wrapper for Twitch made in Python.

https://twitchio.dev

MIT License

791 stars 163 forks source link

Fix for RuntimeError('Event loop is closed') #248

Closed mcmtroffaes closed 2 years ago

mcmtroffaes commented 2 years ago

Pull request summary

As noted in #247, when exiting the bot, a runtime error is given. This appears to be caused by the run function explicitly closing the event loop, whilst some background tasks are still running on the event loop.

Checklist

[x] If code changes were made then they have been tested.
- [ ] I have updated the documentation to reflect the changes.
- [ ] I have updated the changelog with a quick recap of my changes.
[x] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

mcmtroffaes commented 2 years ago

I must admit that I'm not sure whether this is the right solution; it might be better to await for the relevant background task to complete instead, before closing. But I haven't figured out which task it is that is running, as I'm still learning to properly debug async programs.

mcmtroffaes commented 2 years ago

I confirmed all tasks (after applying #247) are closed, at least in the simple test program. The exception appears to be due to an upstream bug related to the event loop implementation in cpython on windows: https://bugs.python.org/issue39232

It seems fine for bot.run() function to call loop.close() since asyncio.run(...) does exactly the same. So closing this PR. Hopefully without runtime errors. 😉