PythonistaGuild / TwitchIO

An Async Bot/API wrapper for Twitch made in Python.
https://twitchio.dev
MIT License
798 stars 163 forks source link

Remove aiohttp contexts #258

Closed tkdrob closed 2 years ago

tkdrob commented 2 years ago

Pull request summary

async with seems to be unnecessary. This PR cleans it up.

Checklist

aaronhnsy commented 2 years ago

afaik, aiohttop context managers are used because the request does not close properly otherwise. In this case you would want to make sure to call ClientResponse.release().

IAmTomahawkx commented 2 years ago

Thanks for the pr, but theres no reason to not use async context managers when they're provided