Fix incorrect User.view_count type

PythonistaGuild / TwitchIO

An Async Bot/API wrapper for Twitch made in Python.

https://twitchio.dev

MIT License

791 stars 163 forks source link

Fix incorrect User.view_count type #266

Closed tkdrob closed 2 years ago

tkdrob commented 2 years ago

Pull request summary

View_count has incorrect type, tuple. This fixes it, int

Checklist

[x] If code changes were made then they have been tested.
- [ ] I have updated the documentation to reflect the changes.
- [x] I have updated the changelog with a quick recap of my changes.
[ ] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[x] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

IAmTomahawkx commented 2 years ago

This is actually a breaking change, and as such can't be introduced into twitchio v2. This may be more appropriate on the v3 branch once http models are fully introduced

tkdrob commented 2 years ago

How close is v2 to being release? I'm working on some other nonbreaking changes so this package can support twitch integration in https://github.com/home-assistant/core

IAmTomahawkx commented 2 years ago

V2 has been released for over a year

chillymosh commented 2 years ago

For info purposes. This payload for view_count is being deprecated and eventually removed completely by Twitch. https://discuss.dev.twitch.tv/t/get-users-api-endpoint-view-count-deprecation/37777