PythonistaGuild / TwitchIO

An Async Bot/API wrapper for Twitch made in Python.
https://twitchio.dev
MIT License
791 stars 163 forks source link

Added fetch_channel_emotes & fetch_global_emotes methods #331

Closed ZebcoWeb closed 1 year ago

ZebcoWeb commented 2 years ago

Pull request summary

Adding Channel and Global emotes API to fetch emotes.

Checklist

IAmTomahawkx commented 1 year ago

also please run black on your changes, as your pr currently fails the lint test

IAmTomahawkx commented 1 year ago

It's also been pointed out to me that these new models haven't been added to the models.rst documentation

ZebcoWeb commented 1 year ago

I'll try to fix these

ZebcoWeb commented 1 year ago

It's also been pointed out to me that these new models haven't been added to the models.rst documentation

How can I add these models to models.rst?

chillymosh commented 1 year ago

It's also been pointed out to me that these new models haven't been added to the models.rst documentation

How can I add these models to models.rst?

docs/reference.rst Please also make sure you have updated the changelog

IAmTomahawkx commented 1 year ago

Hello, all we're missing here is the one mentioned issue with the query parameter in http.py Other than that this is ready to go 👍

IAmTomahawkx commented 1 year ago

I've gone ahead and made the fixes 👍 Thanks for the PR!

ZebcoWeb commented 1 year ago

I've gone ahead and made the fixes 👍 Thanks for the PR!

Good job!