Adds missing append in subscribe_topics (never filled its own _pool List)
Fixes unsubscribing from Pubsub by changing the type passed to unsubscribe_topic in the websocket from groupby to list, because we iterate in _send_topics again. Iterating over an groupby objects results in an empty list.
Pubsub Websocket handles now RECONNECT messages accordingly.
Checklist
[x] If code changes were made then they have been tested.
[x] I have updated the documentation to reflect the changes.
[x] I have updated the changelog with a quick recap of my changes.
[x] This PR fixes an issue.
[x] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)
IAmTomahawkx
commented
1 year ago
Pull request summary
Adds missing append in
subscribe_topics(never filled its own _pool List)Fixes unsubscribing from Pubsub by changing the type passed to
unsubscribe_topicin the websocket from groupby to list, because we iterate in_send_topicsagain. Iterating over an groupby objects results in an empty list.Pubsub Websocket handles now
RECONNECTmessages accordingly.Checklist