PythonistaGuild / TwitchIO

An Async Bot/API wrapper for Twitch made in Python.
https://twitchio.dev
MIT License
791 stars 163 forks source link

fix a forgotten nonce #338

Closed dzmuh97 closed 1 year ago

dzmuh97 commented 1 year ago

Pull request summary

After we subscribe to topics we wait for the event_pubsub_nonce, but it is not called because the server does not pass the nonce it should return in response to the client, which we wait for in websocket.py:200

Checklist

chillymosh commented 1 year ago

This is most likely because the nonce is optional here, so was either overlooked or deemed not necessary at the time.

It doesn't prevent the use of the extension.

chillymosh commented 1 year ago

@dzmuh97 could you please complete the PR request