Closed jbot-the-dev closed 1 year ago
Technically this doesn't fix an issue, it would also now cause inconsistencies in the eventsub module as the event that is dispatched is also called revokcation as well as the model.
In it's current state, "eventsub_revokation" will never be run, because message type "revokation" does not exist. I have personally run into this issue when debugging. Please look at my reference under "Twitch-Eventsub-Message-Type".
I do understand there will be inconsistencies, I left them because fixing them would be considered a breaking change.
Ah I didn't read your change properly, thanks.
It looks like GitHub had auto-filled some details from the other pull request I was working on. I separated the two because they address separate issues. I have fixed the summary now.
Thanks 👍
Pull request summary
"Revokation" is a typo and does not match the message type "revocation" that Twitch uses. I do not have the means to test this at the moment, though I have implemented this fix successfully in a modified version of this library. I don't see reference to this in the documentation, so I don't think that needs updated. There are other uses of "revokation", though fixing them would fall into the category of a breaking change, so I left them alone for now.
Reference: https://dev.twitch.tv/docs/eventsub/handling-webhook-events
Checklist