search

PythonistaGuild / TwitchIO

An Async Bot/API wrapper for Twitch made in Python.
https://twitchio.dev
MIT License
791 stars 163 forks source link

Proper handling of connection exceptions #344

Closed Commaster closed 1 year ago

Commaster commented 1 year ago

Currently in https://github.com/TwitchIO/TwitchIO/blob/master/twitchio/http.py#L274-L277 we have exceptions that are never handled and raised into nowhere ( https://github.com/TwitchIO/TwitchIO/blob/master/twitchio/client.py#L158 -> https://github.com/TwitchIO/TwitchIO/blob/master/twitchio/websocket.py#L125 ) leading to a silent Task exception was never retrieved in the logfile. There should be a way to programmatically detect these situations, without falling back to using start() instead of run().

At the moment I only wait for event_ready, which obviously never happens.

github-actions[bot] commented 1 year ago

Hello! Thanks for the issue. If this is a general help question, for a faster response consider joining the official Discord Server

Else if you have an issue with the library please wait for someone to help you here.