search

PythonistaGuild / TwitchIO

An Async Bot/API wrapper for Twitch made in Python.
https://twitchio.dev
MIT License
791 stars 163 forks source link

Add "created_at" and "ended_at" parameters when fetching Twitch clips #353

Closed graille closed 1 year ago

graille commented 1 year ago

Twitch endpoint to get clips allows the usage of "started_at" and "ended_at" parameters to avoid server and network overload when you only needs clips generated at a specific date.

The TwitchIO method doesn't implement this. So we always have to transfer all the clips of the channel (1500+ in my case) and then, sort them by date afterwards.

Would be nice to add two new parameters to the function.

github-actions[bot] commented 1 year ago

Hello! Thanks for the issue. If this is a general help question, for a faster response consider joining the official Discord Server

Else if you have an issue with the library please wait for someone to help you here.

chillymosh commented 1 year ago

I believe you meant to link the PartialUser.fetch_clips method?

graille commented 1 year ago

I believe you meant to link the PartialUser.fetch_clips method?

Yep sorry, I edited my first message

chillymosh commented 1 year ago

This has been implemented in 4ad023df664c60009ee49de92d5722fd641bb5f3. Please test and provide feedback if needed.