PythonistaGuild / TwitchIO

An Async Bot/API wrapper for Twitch made in Python.
https://twitchio.dev
MIT License
785 stars 163 forks source link

Pyproject toml #405

Closed joelsgp closed 1 year ago

joelsgp commented 1 year ago

Pull request summary

This replaces setup.py with pyproject.toml this is needed because setup.py is deprecated

Another advantage is this lets us embed the 120 character line limit in the settings, so Black will use it automatically

Checklist

IAmTomahawkx commented 1 year ago

Hi there, thanks for the PR but we're not looking to migrate to pyproject.toml at this time

IAmTomahawkx commented 1 year ago

It should be noted that our 3.0 branch does make use of pyproject.toml, however the setup.py file is not entirely deprecated. Invoking the file directly is indeed deprecated, however the setup.py file is still fine by itself

joelsgp commented 1 year ago

Ah I should have checked 3.0 thanks, didn't realise that was the working branch

joelsgp commented 1 year ago

I think using pipenv would be quite good for managing the dependencies and extras, you can use pipenv requirements > requirements.txt to make the requirements.txt off it too