Closed joelsgp closed 1 year ago
hi there, as the docs build has pointed out, 3.7 does not have Literal in the typing module. as such, the typing_extensions version is used throughout the module. Additionally, you appear to have removed the future annotation imports?
If you have further PRs to make, i would suggest joining our discord, which is linked in the README, to discuss them first
3.7 is about to go end-of-life https://devguide.python.org/versions/
I'm already in the discord but I should have checked the docs section on this before submitting. I was mistaken on the future imports, I thought that was already mandatory but it's tbd https://docs.python.org/3/library/__future__.html
Python 2.7 is also EoL but people still use it and rely on it in companies :)
Python 2.7 is also EoL but people still use it and rely on it in companies :)
I'm sorry to hear that, I will pray for them 🙏
our support is not based around the timing the python org provides for lifecycles. We will provide support for 3.7+ for the lifetime of this semver cycle (V2). We will drop support for older python versions in our next cycle (V3)
Understood, and I'd appreciate it if the semantic versioning / version branch model was explained in https://github.com/TwitchIO/TwitchIO#contributing for future reference
Pull request summary
Literal
is now in the standard library. Also remove the old annotations imports, as the relevant python versions are no longer supported.Checklist