When requesting albums, the Spotify API only returns SimplifiedTrackObjects that do not contain all the track information received when requesting tracks or playlists. #197 attempted to resolved this by making the ISRC optional on SpotifyTracks. However, Wavelink uses the ISRC of SpotifyTracks in their fulfill function.
In both #219 and my own observations these missing ISRC have resulted in the incorrect song to be repeatedly found. This PR would resolve the SimplifiedTrackObjects into full ones, preventing this issue, as well as end #209.
Additional it resolves the issue discussed in #221 without any breaking changes to those not using return_first. (On this change feel free to correct me if the instance check against SpotifyTrack is too narrow).
Finally, it would correct the minor error causing playlist searches to error when not using the iterator.
When requesting albums, the Spotify API only returns SimplifiedTrackObjects that do not contain all the track information received when requesting tracks or playlists. #197 attempted to resolved this by making the ISRC optional on SpotifyTracks. However, Wavelink uses the ISRC of SpotifyTracks in their fulfill function.
In both #219 and my own observations these missing ISRC have resulted in the incorrect song to be repeatedly found. This PR would resolve the SimplifiedTrackObjects into full ones, preventing this issue, as well as end #209.
Additional it resolves the issue discussed in #221 without any breaking changes to those not using return_first. (On this change feel free to correct me if the instance check against SpotifyTrack is too narrow).
Finally, it would correct the minor error causing playlist searches to error when not using the iterator.