search

PythonistaGuild / Wavelink

A powerful Lavalink library for Discord.py.
https://wavelink.dev
MIT License
389 stars 179 forks source link

Clean up some typing syntax #247

Closed Sachaa-Thanasius closed 9 months ago

Sachaa-Thanasius commented 10 months ago

Ideally, this doesn't result in any change to the functionality; it's more about making the typing syntax consistent with python 3.10+ and ensuring pyright flags it accordingly if it isn't.

Sachaa-Thanasius commented 10 months ago

Maybe more could be done, but this feels like it could be enough for a PR that doesn't add functionality.

EvieePy commented 9 months ago

Has this been tested in terms of actually being able to be ran? With like simple.py or something?

Sachaa-Thanasius commented 9 months ago

Has this been tested in terms of actually being able to be ran? With like simple.py or something?

Yep. It works fine with simple.py on my machine, though I didn't run it exhaustively — I loaded up "Ocean Drive" and a "Rock Classics" Spotify playlist (courtesy of the examples in the migrating docs) and just let it go for a while.