search

PythonistaGuild / Wavelink

A powerful Lavalink library for Discord.py.
https://wavelink.dev
MIT License
389 stars 179 forks source link

[feature/v3] TrackEndEventPayload.player is often missing #252

Closed atomic-junky closed 9 months ago

atomic-junky commented 9 months ago

Hi, Almost every time a track_end event is issued, the player attribute is missing on the v3 branch. I think it also happens a few times for the track_start event, but it's rarer. (I'm using Lavalink v4.0.0-beta.5)

Btw thanks for maintaining wavelink

EvieePy commented 9 months ago

I doubt this is happening unless you are disconnecting the player or removing it from the node. I have tested AutoPlay extensively and it requires a player to be available at the time this event fires to work.

Almost everytime seems weird, Everytime could be a bad bug?

Are you able to provide your wavelink version, and sample code of your events and play command.

You can run py -m wavelink --version

atomic-junky commented 9 months ago

I didn't manage to reproduce the bug, I may have set it unintentionally but I had the impression that it only happened with the normal queue. It's very likely that the mistake came from me, but is it possible that it came from Lavalink? Sorry for the inconvenience, I don't know what happened.

EvieePy commented 9 months ago

Not sure tbh. Are you able to run simple.py and add a track end to that and try printing the player? Also do you know your wavelink version?

EvieePy commented 9 months ago

Sorry reopening, because I would like to know if there is a potential bug here or not.

atomic-junky commented 9 months ago

I have wavelink 3.0.0rc1 and when I run simple.py all goes well and with my personal bot too