search

PyvesB / PetMaster

:cat: Minecraft plugin to manage pets and display useful information via holograms, action bar or chat messages.
GNU General Public License v3.0
50 stars 26 forks source link

[Request] Pet protection #26

Closed Foxzes closed 3 years ago

Foxzes commented 5 years ago

Hello! I love the plugin, but if a player is evil enough they could still kill a pet.

As a solution, could you add an option to exclude pets from all types of damage? Essentially making them immortal? I would greatly appreciate it.

Another quick comment, a config option to include nametagged animals in this would be loved too.

Zijuna commented 5 years ago

disablePlayerDamage already does this, doesnt it?

PyvesB commented 5 years ago

Hello @Foxzes,

The issue with excluding all types of damage is that it would also cover adverse mobs, falling or any other form of external damage made to pets, not just player-induced damage. I'm unsure many users would find such a feature useful. 😉

Cheers,

Pyves

FocuzJS commented 5 years ago

actually no, my friend griefed my dog by shooting it with arrows via dispenser lol @Zijuna

abclution commented 5 years ago

I would actually just like to disable pet damage from myself. Dogs always getting swords to the side of their head when I'm in battle.

disablePlayerDamage only protect pets from other players from what I can tell.

PyvesB commented 5 years ago

I don't have enough spare time to work on this feature request right now, but I'm happy to review pull requests from external contributions! :wink:

PyvesB commented 4 years ago

Two new options are available: disableLeash and disableRiding. These should further protect your pets against malicious other players.

anselhelm commented 3 years ago

Good day,

I personally would find a configurable "protection" option on tamed entities to be invaluable. As it is, I end up leaving pets sitting in a base, so that they don't die. If there were a way to protect them from all damage types, this would be amazing, as they could travel the world with me.

Is there anything that might persuade you to put in place such an option? I cannot offer to contribute any code myself, as I simply don't have the knack for coding, as sadly I've learnt over the last few decades.

PyvesB commented 3 years ago

I really don't have time to work on this - check out my GitHub profile, you'll see that I'm pretty busy when it comes to open-source. As far as this project is concerned, I'm only ensuring essential maintenance and reviewing the occasional contribution.

As pointed out in #45, I'm really keen on getting help from new maintainers to keep improving this great little plugin! Your best bet would be to spread the word and engaging with people so that they join the adventure. 😉