PyvesB / advanced-achievements

:fireworks: Popular plugin that adds unique and challenging achievements to Minecraft servers.
https://www.spigotmc.org/resources/83466
GNU General Public License v3.0
200 stars 214 forks source link

Portuguese language: Added newer messages from lang.yml and translated then. #1023

Closed C0ffeL0Ve closed 3 years ago

C0ffeL0Ve commented 3 years ago

i did not altered the Header of the file so maybe it needs to have the latest version in there

PyvesB commented 3 years ago

Hello @C0ffeL0Ve ! 👋🏻

Thanks for the contribution! Ideally, the header should be updated to match the new style that was introduced in version 7.0.0 of the plugin, but I can also take care of it later if you're not too comfortable with Git. Let me know. 😉

C0ffeL0Ve commented 3 years ago

To tell you the truth. I don't know how to do this, I tried learning on how to use the console from git but it was no luck, When updating the file I just forked this project and conected with git Gui/Opened Vs studio/Compared the two files together in the same page and pasted the new messages into the outdated file.

If you meant by copying and pasting the header from the updated text file and pasting into the outdated one I could do that, What about the name of the editor? do I change it?

Thinking more I think its best leaving this to the Pro :)

edit: If there is a method of updating a older file without losing the original text i would like to know, not just for this plugin but for other plugins so i can translate a little more faster.

PyvesB commented 3 years ago

What about the name of the editor? do I change it?

Adding your name to the list, like you did, is fine :)

If there is a method of updating a older file without losing the original text

I'm unsure what you mean, could you please clarify?

C0ffeL0Ve commented 3 years ago

Its nothing important. It's just that it was tiring to copy the new language line from a updated file and dragging to the older file so the language would work. My question was if there is an automated way of doing that without losing the contents from the older file.

Right now in this version if i change the language to lang-PB.yml the plugin crash because the lines from the latest version are missing so i had to manually drag and drop/translate the new lines( i was just wondering if there is a automated way of drag and drop new lines without losing the actual content, this is for other plugins that if i translate on the future)

PyvesB commented 3 years ago

Right now in this version if i change the language to lang-PB.yml the plugin crash because the lines from the latest version are missing so i had to manually drag and drop/translate the new lines

This is not expected, in theory the plugin should copy all the new values from the latest English version to the old Portuguese file, which makes translating the updated file really easy. Could you please raise a separate issue, so that I can merge this update in the meantime? :)

C0ffeL0Ve commented 3 years ago

sorry haha, ok merge this update