PyvesB / advanced-achievements

:fireworks: Popular plugin that adds unique and challenging achievements to Minecraft servers.
https://www.spigotmc.org/resources/83466
GNU General Public License v3.0
200 stars 214 forks source link

Book size #1034

Closed LuluxClient closed 3 years ago

LuluxClient commented 3 years ago

:information_source: Basic information

:beetle: Description The /aach book if you have a lot of achievements it can kick you or prevent you from opening it because of anticrash plugins (byte size to big) and it can be used for duping (exploit with books).

If possible if instead of a book it could be in chat ?

Do /aach book try and stack around 27 books with over 50 pages log on a hacked client that has the book dupe, do the dupe (move the books etc) log off and relog and boom you duped ! :page_facing_up: Server logs No errors don't need

don't need

:wrench: Configuration

don't need
PyvesB commented 3 years ago

Hello @LuluxClient ! 👋🏻

This really seems out of scope of Advanced Achievements. If third party plugins are blocking books, those need to be reconfigured or removed, and if you don't want books as all, you can simply disable the command. 😉

LuluxClient commented 3 years ago

Hello @LuluxClient ! 👋🏻

This really seems out of scope of Advanced Achievements. If third party plugins are blocking books, those need to be reconfigured or removed, and if you don't want books as all, you can simply disable the command. 😉

but I would like to have it in a chat format since 99% of the servers are blocking books

PyvesB commented 3 years ago

99% of the servers are blocking books

It's the first that I'm hearing about servers blocking books, so I'm not convinced about this number.

Chat format wouldn't work: there's only a limited scroll back buffer imposed by Minecraft, if as you say you've got many achievements, most would probably not even fit. That's why there's an /aach list command which lists all achievements in a nice GUI. 😉

LuluxClient commented 3 years ago

99% of the servers are blocking books

It's the first that I'm hearing about servers blocking books, so I'm not convinced about this number.

Chat format wouldn't work: there's only a limited scroll back buffer imposed by Minecraft, if as you say you've got many achievements, most would probably not even fit. That's why there's an /aach list command which lists all achievements in a nice GUI. 😉

Well the gui is really not configurable and it's not that good looking, I had to block the command on my server because of that and more. Well maybe a chat page system

PyvesB commented 3 years ago

the gui is really not configurable and it's not that good looking

You can change every single text including its formatting style and colour, you can change every single object icon, whether it be for the categories or the individual achievements, you can change the ordering of every single element, again whether it be for categories and achievements, you can completely disable texts you don't want, you've got over a dozen additional configuration options in config.yml to further customise the appearance and behaviour of the GUI, you can invoke subparts of the GUI directly via a commands to further customise the user journey, you've got the source code fully available if you want to further expand on the countless existing features. You've even got a second Vanilla GUI available via /aach generate and that one is fully customisable as well. I'm struggling to think about something that actually isn't configurable.

Closing as we've deviated quite far from the initial issue and your last two messages seem more aimed at twisting reality than engaging in a constructive discussion. :)

LuluxClient commented 3 years ago

Not really, it's just it's not that configurable, if I want to change a color for something it will for everything, I have to hire a dev to do this modification, it's really not that good...