PyvesB / advanced-achievements

:fireworks: Popular plugin that adds unique and challenging achievements to Minecraft servers.
https://www.spigotmc.org/resources/83466
GNU General Public License v3.0
200 stars 211 forks source link

Better appearance and a few new features #1045

Closed GejmronCZ closed 3 years ago

GejmronCZ commented 3 years ago

New features in config/gui

Only for author: gejmroncz@seznam.cz

PyvesB commented 3 years ago

Hello @GejmronCZ ! 👋🏻

achievements_enchant: true/false achievements_enchant_sub: true/false

I believe that the enchantment information will appear when hovering over the items in the GUI, which will be confusing for users. This is a Minecraft limitation and I'm not aware of any ways to disable it.

achievements_lore: true/false achievements_lore_sub: true/false

I do not understand the benefit of these options. Why would one want to disable lores for categories for which all achievements have been received?

GejmronCZ commented 3 years ago

Hello @PyvesB

  1. You can add any enchant you want like Unbreaking X in much plugins.
  2. No, you misunderstood that. I meant it overall, not after getting it. If you want them there, leave them on, if not, turn them off. That is all.
PyvesB commented 3 years ago
2\. No, you misunderstood that. I meant it overall, not after getting it. If you want them there, leave them on, if not, turn them off. That is all.

If all lores are removed, you can no longer tell which achievement is which, can you? I don't see the point.

GejmronCZ commented 3 years ago

Dude, you should probably realize what the name is and what lore. I didn't say a word about the names, only about the additional lore as a reward / easter egg.

PyvesB commented 3 years ago

I'm not sensing this discussion as being very constructive. Next time you want to interact with an open-source community, I also recommend using a non-abusive profile picture.

GejmronCZ commented 3 years ago

This string is only my idea how to make this plugin better. It's not my problem that you don't know the concepts. BTW it's just a profile picture, nothing more. Everyone can have the profile they want. I like that movie.

If you still have any questions, I'll be happy to answer them. :)