PyvesB / advanced-achievements

:fireworks: Popular plugin that adds unique and challenging achievements to Minecraft servers.
https://www.spigotmc.org/resources/83466
GNU General Public License v3.0
200 stars 211 forks source link

lang line problem #1065

Closed EdgarGDE closed 2 years ago

EdgarGDE commented 2 years ago

🎆 Advanced Achievements version

7.2.0

🖥 Server version

Tuinity 1.16.5 Latest stable version

🚰 Spigot username

DarthEdard

𝑾 Wiki read

📁 Existing issues

❓ Description

I can't set the following line inside config.yml:

Currently my line is like this: "achievement-new: '§aLogro Desbloqueado:'" (Ignore "") But I want to do it like this, in some way possible! "achievement-new: '§e§kw §a>> Logro Desbloqueado: §6%aach_new_achievement% §a<< §e§kw'"

Is possible?

The problem is that AACH detects the end of the text inside the quotes as the achievement unlocked, which means that I cannot select a full format because it will be interrupted, I will show examples, if I manage to upload images it will be better.

⚙ Configuration

achievement-new: '§aLogro Desbloqueado:'
PyvesB commented 2 years ago

Hello @EdgarGDE ! :wave:

I will show examples, if I manage to upload images it will be better.

Yes, images would be great! You can simply drag and drop them in GitHub. 😉

PyvesB commented 2 years ago

I've implemented something that I believe corresponds to what you want, closing.

EdgarGDE commented 2 years ago

I've implemented something that I believe corresponds to what you want, closing.

Sorry! I didn't answer because I completely forgot! I had emergency exits and my time is gone

EdgarGDE commented 2 years ago

Let me look for the option and show you what I'm talking about, basically AACH does not allow to change the message that appears when you unlock an achievement (in chat)

EdgarGDE commented 2 years ago

Because there is no placeholder to identify the new achievement, AACH uses the end of that line as a "placeholder" and the achievement appears there.

EdgarGDE commented 2 years ago

File: lang.yml achievement-new: '§aNew Unlocked AACH:' #Here is the problem. When the achievement appears in-game, it looks like this: §aNew Unlocked AACH: Here is the AACH! If I wanted the game to show it like this: &e&k123 §aNew Unlocked AACH: &6Here is the AACH! &e&k123 It would change the line like this: achievement-new: '&e&k123 §aNew Unlocked AACH: &6%new-placeholder-needed% &e&k123' But no placeholder exist :( Is needed

PyvesB commented 2 years ago

I believe that's what I implemented, all is good :)

EdgarGDE commented 2 years ago

Because the original line detects that the end of the line is where the achievement will appear. achievement-new: '§aNew Unlocked AACH: #(here appear the aach)' #Here is the problem.

EdgarGDE commented 2 years ago

Wow, really? what is the new placeholder or the new setting?

PyvesB commented 2 years ago

Both achievement-new and achievement-received in lang.yml will now support an ACH placeholder, similarly to a few other messages in that file. 😉

EdgarGDE commented 2 years ago

I add them with %%? Example: %achievement-new%

PyvesB commented 2 years ago

Well no, you'll simply need to use the ACH placeholder, for example: achievement-new: '§e§kw §a>> Logro Desbloqueado: §6ACH §a<< §e§kw'

EdgarGDE commented 2 years ago

Really if it is what you wanted! but it does not work! watch this :(

EdgarGDE commented 2 years ago

https://imgur.com/KAbTY2x (Not working) https://imgur.com/EcKJECK (Working, But is another plugin of "Souls" xd) My line: achievement-new: ' §e§kw§a>> Logro Desbloqueado: §6ACH §a<<§e§kw'

PyvesB commented 2 years ago

Are you sure you've correctly recompiled the plugin from source?

EdgarGDE commented 2 years ago

What does it mean? I bought the plugin a few months ago and I am using the most current version. Do you need me to show you my logs or any special data?

PyvesB commented 2 years ago

As you'll have noted, this feature was implemented three hours ago. If you're trying to use it in the current Spigot version which was released several days ago, it will not work. If you were familiar with Maven and Git, you could build the project's source code yourself, but it's probably simpler to just wait for the next release. :)

EdgarGDE commented 2 years ago

Oh I understand! I don't know how to do that because I'm not a developer :(

EdgarGDE commented 2 years ago

Sorry to bother you, but that role will be official, right?

PyvesB commented 2 years ago

Sorry to bother you, but that role will be official, right?

What do you mean by "that role"?

EdgarGDE commented 2 years ago

Hi there! Now it works, I tried the update and it is great!

EdgarGDE commented 2 years ago

Sorry, if you don't understand me in some words, I don't speak English and I use a translator! but thanks!!! :D <3

PyvesB commented 2 years ago

It's okay! Glad you're enjoying the update!