Achievement tracking problems

[evanmcclan]

Plugin version: 5.7.2 Minecraft verison: CraftBukkit version git-Spigot-5695bca-53fccdf (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

Problem: For all of my achievements (especially in the custom categories). the plugin doesn't track if the player already has the achievement before giving it to them. Because of this it allows the player to keep receiving the same achievement over again through the give command or through console. Please fix this issue because achievements should only be given one time and the reward only one time (unless the admin removes the achievement from the player in which case they can get it back again).

Another problem is in the aach list command GUI. All the items in the gui can be removed, all the blocks for each achievement can be taken out of the GUI and put into a players inventory when they shouldn't be.

for all of the errors ive mentioned, the plugin generates no error messages in the console at all.

[PyvesB]

Hello @evanmcclan ,

I suggest reading the plugin's configuration file as well as the Wiki. 😉

Cheers,

Pyves

[evanmcclan]

@PyvesB I read the configuration and the Lang.YML file. It appears that there is no errors in the yml and there is no UTF-encoding issues. Ive tried every method i could think of to figure out why items in aach list are still removabled from the GUI. Any suggestions?

[PyvesB]

Could you please share your lang.yml file so I can take a look?

[evanmcclan]

@PyvesB https://pastebin.com/bW4X4fkT (Sorry for the late response)

[PyvesB]

I am not able to reproduce this issue with your configuration, I am suspecting some sort of conflict with another plugin. Do things work fine when Advanced Achievements is the only plugin running on the server?

[evanmcclan]

@PyvesB When AdvancedAchievements is running as the only plugin on the server it does work. What types of plugins would most likely conflict? Economy | GUI | CustomCommand Makers | Protocol Plugins ....?

Here is a list of plugins That AdvancedAchievements is running along with, ive been disabling them and restarting Advanced achievements but no changes have been apparent 10.05 14:18:10 [Server] INFO Plugins (74): CleanroomGenerator, ComplexStructures, OnTheClock, NoCollisionPlugin, PlaceholderAPI, PerWorldPlugins, PlugMan, CrispyAntiWDL, CameraObscura, NametagEdit, WaterRedstone, ConsoleSpamFix, SimpleBackup, Tablist, MagicEars, SketchMap, PacketListenerApi, WorldBorder, EPSuite, MessageAnnouncer, ProtocolLib, eZProtector, FastAsyncWorldEdit, HubThat, PermissionsEx, Vault, ServerListPlus, ProtocolSupport, CrazyCrates, ClearChat, BKCommonLib, Herochat, PwnFilter, PerWorldInventory, MyCommand, WorldEdit, War, Essentials, ScLoad, HeadDatabase, CustomGUI, Train_Carts, EssentialsChat, Parkour, ProtocolSupportStuff, JLib, TCFloatRail, PlotSquared, WorldGuard, TCHangRail, EssentialsProtect, EssentialsGeoIP, EssentialsAntiBuild, EssentialsSpawn, Multiverse-Core, HeavySpleef, Hotels, Multiverse-Portals, ArmorStandTools, ReActions, Grifball, HolographicDisplays, MCJukebox, ProtectionLib, MinecraftMarket, WirelessRedstone, Animatronics, Paintball, FurnitureLib, DiceFurniture, ItemJoin, UltimateRides, AutoQueue, AdvancedAchievements

[PyvesB]

Most likely the GUI or Protocol plugins, but as I don't know most of these plugins, it's hard to tell. I suggest trying to re-enable your plugins by batches of 5-10, and see when Advanced Achievements stops working properly. You can then search the specific plugin within that batch. Once we've spotted the culprit, we can carry on from there. ^^

[evanmcclan]

Ok I think ive found the problem. When I Re-add EssentialsX The Achievements list gui breaks @PyvesB

[PyvesB]

I have downloaded the latest version of EssentialsX (2.15.0.1) with the default configuration files and am not able to reproduce the issue with Advanced Achievements 5.7.4. Could you please share your EssentialsX configuration?

[evanmcclan]

@PyvesB Hi sorry it took me so long to respond, my email notifications stopped working. Attatched below is my config.

https://pastebin.com/8a4uxfdg

[PyvesB]

Unfortunately I'm still not able to reproduce the issue. Let's try a different strategy here. I have attached a test version that contains some additional log lines. Could you please try to get an item out of the GUI and show me the messages from Advanced Achievements that appear in the console's output?

AdvancedAchievements.zip

[evanmcclan]

@PyvesB The Jar you gave me works, the items cant be clicked out of the GUI and the console outputs this; 23.05 16:20:34 [Server] INFO Evan_McClan issued server command: /aach list 23.05 16:20:36 [Server] INFO Inventory name is "My Achievements" 23.05 16:20:36 [Server] INFO Event cancelled : true Is there a way to remove the 1 it puts after the GUI name or is that a page number?

[PyvesB]

Wait a minute, I haven't actually made any actual changes apart from the logging, the jar should be functionally equivalent to version 5.7.4 of the plugin. Does it break again when you switch back to the latest official version of the plugin?

[evanmcclan]

the latest version now no longer lets me remove the items from the GUI, however, the gui title still adds the number 1 when i open a category @PyvesB

[PyvesB]

Oops accidentally deleted my comment, rewriting it.

1 -> page number. Not a big fan either, but have yet to find a better way of keeping track of the page number.

I'm guessing you changed something else on your side, as this functionality has not been modified between versions 5.7.2 and 5.7.4 of the plugin. I noticed you updated list-gui-title, which actually previously contained an apostrophe. This may have cause problems as it's a special character in YAML.

[PyvesB]

Closing this issue. Please upgrade to version 5.8.0 of the plugin once it's released, there are some improvements regarding things we discussed here. 😉