PyvesB / advanced-achievements

:fireworks: Popular plugin that adds unique and challenging achievements to Minecraft servers.

https://www.spigotmc.org/resources/83466

GNU General Public License v3.0

199 stars 215 forks source link

Placeholder in Lang.yml don't work #478

Closed BijuuKrunos closed 5 years ago

BijuuKrunos commented 5 years ago

The Placeholders of the Plugin itself do not work in the lang.yml.

In game i just become the Placeholder but not what it should be.

PLAYER is in the game still PLAYER...

tested with lang-DE.yml and with lang.yml.

newest Version of aach on MC 1.13.2 with paperspigot.

Nothing in the console.

PyvesB commented 5 years ago

Hello @BijuuKrunos,

Not all fields in lang.yml support the PLAYER placeholder. Which specific one are you having trouble with?

Cheers,

Pyves

BijuuKrunos commented 5 years ago

Just as I said. Its even in the default lang. I did not changed anything or used it on lines there it wasn't before xD. German lang as well. Nothing changed and the placeholder doesn't work. :)

Greetz,

Krunos

PyvesB commented 5 years ago

My above question still stands: which field is causing issues? About 8 of them support the PLAYER placeholder.

BijuuKrunos commented 5 years ago

Okey fail. now i tested it even more. and yeah it was my failure. for example: achievement-given in the default lang.yml: "Achievement given!" in the lang-DE.yml: "Der Spieler PLAYER hat den Erfolg erhalten!"

the lang-DE.yml is not working xD sry. Just changed it for myself.

closed

PyvesB commented 5 years ago

Ideally the German translation should be updated to reflect what is now available in a recent version of the plugin, feel free to submit a pull request!